Skip to content

Bring omniauth-github up-to-date #61

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Feb 1, 2017
Merged

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Aug 7, 2016

@mbleigh - Please consider this PR and update RubyGems accordingly. The current version is out-of-date by over two years and contains security vulnerabilities. Thanks!


This PR does the following:

Security Updates

  • Uses https for the RubyGems URL to pass bundler audit

Dependencies

  • Bumps omniauth to ~>1.3.2
  • Bumps omniauth-oauth2 to ~> 1.4.0
  • Bumps rspec to ~> 3.5

Specs

  • Updates specs to RSpec 3+ syntax

Housekeeping

  • Ensure similar code formatting in specs
  • Bump gem version to 1.2.0

Closes #59
Closes #52
Closes #57

@tmilewski
Copy link
Member Author

Updates per @yaodong and @boutil's issues.

@tmilewski
Copy link
Member Author

tmilewski commented Aug 28, 2016

Ping @mbleigh & @intridea-shared

@mbleigh
Copy link
Contributor

mbleigh commented Aug 28, 2016

I don't actively maintain this gem anymore. @sferik is this one of the many
you're on?

On Sun, Aug 28, 2016, 3:00 PM Tom Milewski notifications@github.com wrote:

Ping @mbleigh https://github.com/mbleigh


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#61 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAD_nFid6tC5XEg5hEXv7DYFYbnFuiBks5qkgTzgaJpZM4JebJ1
.

@tmilewski
Copy link
Member Author

@mbleigh All good, I just want to make sure it gets updated so that there's no longer any security concerns through out-of-date dependencies.

As time permits, I'm happy to take over some maintenance responsibilities as well.

@tmilewski
Copy link
Member Author

Ping @sferik, are you an owner?

@joegoggins
Copy link

No response in ~4 months would indicate that @sferik is not a maintainer.

@mbleigh , any chance you could widen the maintainer pool to include @tmilewski so this could get merged and released to rubygems?

@mbleigh
Copy link
Contributor

mbleigh commented Jan 31, 2017

@tmilewski you've been added.

@sferik
Copy link

sferik commented Feb 1, 2017

Sorry, just seeing this now…

@tmilewski Welcome to the team!

@tmilewski
Copy link
Member Author

@mbleigh @sferik Thanks guys! Going through this now!

@tmilewski tmilewski merged commit 443a6b3 into omniauth:master Feb 1, 2017
@tmilewski
Copy link
Member Author

tmilewski commented Feb 1, 2017

@mbleigh:
Mind adding me to RubyGems so that I may push this out to the world? Thanks!
gem owner omniauth-github --add tmilewski@gmail.com


All:
In the meantime, this will work...
gem 'omniauth-github', git: 'https://github.com/intridea/omniauth-github.git', tag: '1.2.0'

Excited!

@mbleigh
Copy link
Contributor

mbleigh commented Feb 1, 2017

@tmilewski the power is yours!

Captain Planet

@tmilewski
Copy link
Member Author

@mbleigh Perfect, thank you! It's now live!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants